Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TYP: ExtensionIndex #38783

Merged
merged 2 commits into from
Dec 29, 2020
Merged

TYP: ExtensionIndex #38783

merged 2 commits into from
Dec 29, 2020

Conversation

jbrockmendel
Copy link
Member

No description provided.

@jreback jreback added ExtensionArray Extending pandas with custom dtypes or arrays. Index Related to the Index class or subclasses Typing type annotations, mypy/pyright type checking labels Dec 29, 2020
jreback
jreback reviewed Dec 29, 2020
View reviewed changes
pandas/core/arrays/_mixins.py Outdated
@@ -325,7 +325,7 @@ def __repr__(self) -> str:
# ------------------------------------------------------------------------
# __array_function__ methods

def putmask(self, mask, value):
def putmask(self: NDArrayBackedExtensionArrayT, mask: np.ndarray, value):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> None right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated+green

@jreback jreback added this to the 1.3 milestone Dec 29, 2020
@jreback jreback merged commit 9415d10 into pandas-dev:master Dec 29, 2020
@jbrockmendel jbrockmendel deleted the ref-share-indexes branch December 29, 2020 20:33
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@jbrockmendel @luckyvs1
TYP: ExtensionIndex (pandas-dev#38783)
3aa3e8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

Assignees
No one assigned
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. Index Related to the Index class or subclasses Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback